ivanzlenko commented on code in PR #5935:
URL: https://github.com/apache/ignite-3/pull/5935#discussion_r2115817964


##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointReadWriteLock.java:
##########
@@ -32,6 +37,11 @@ public class CheckpointReadWriteLock {
      */
     static final String CHECKPOINT_RUNNER_THREAD_PREFIX = "checkpoint-runner";
 
+    private static final long LONG_LOCK_THRESHOLD_MILLIS = 1000;
+    public static final String LONG_LOCK_THROTTLE_KEY = "long-lock";

Review Comment:
   Let's not make it public if we want to keep it there. Is there a chance if 
we will use this key elsewhere? 



##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointReadWriteLock.java:
##########
@@ -44,9 +54,11 @@ public class CheckpointReadWriteLock {
      * Constructor.
      *
      * @param checkpointLock Checkpoint lock.
+     * @param throttledLogExecutor Executor to throttle log.

Review Comment:
   ```suggestion
        * @param throttledLogExecutor Executor for the throttled loggers.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to