korlov42 commented on code in PR #5838:
URL: https://github.com/apache/ignite-3/pull/5838#discussion_r2111492420
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/TypeUtilsTest.java:
##########
@@ -444,13 +444,15 @@ public Stream<DynamicTest> testSimpleTypesConversion() {
// Year intervals are stored as days (int)
Review Comment:
outdated comment
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/util/TypeUtilsTest.java:
##########
@@ -444,13 +444,15 @@ public Stream<DynamicTest> testSimpleTypesConversion() {
// Year intervals are stored as days (int)
for (SqlTypeName interval : SqlTypeName.YEAR_INTERVAL_TYPES) {
SqlIntervalQualifier yearMonth = new
SqlIntervalQualifier(interval.getStartUnit(), interval.getEndUnit(),
SqlParserPos.ZERO);
- testCaseList.add(new
RelToExecTestCase(TYPE_FACTORY.createSqlIntervalType(yearMonth), INT32));
+ testCaseList.add(new
RelToExecTestCase(TYPE_FACTORY.createSqlIntervalType(yearMonth),
+ RowSchemaTypes.nativeType(NativeTypes.PERIOD)));
}
// Day intervals are stored as nanoseconds (long)
Review Comment:
this one as well
##########
modules/core/src/main/java/org/apache/ignite/internal/lang/InternalTuple.java:
##########
@@ -220,6 +221,14 @@ public interface InternalTuple {
*/
Instant timestampValue(int col);
+ /**
+ * Reads value for specified column.
+ *
+ * @param col Column index.
+ * @return Column value.
+ */
+ Period periodValue(int col);
Review Comment:
what about duration?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
