Copilot commented on code in PR #12102:
URL: https://github.com/apache/ignite/pull/12102#discussion_r2109404417


##########
modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/BinaryUtils.cs:
##########
@@ -808,8 +808,8 @@ public static void WriteDecimal(decimal val, IBinaryStream 
stream)
                 neg = true;
             }
 
-            if (scale < 0 || scale > 28)
-                throw new BinaryObjectException("Decimal value scale overflow 
(must be between 0 and 28): " + scale);
+            if (-28 > scale || scale > 28)

Review Comment:
   [nitpick] Consider using a more intuitive comparison—for example, 'if (scale 
< -28 || scale > 28)'—to improve readability.
   ```suggestion
               if (scale < -28 || scale > 28)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to