Copilot commented on code in PR #5879:
URL: https://github.com/apache/ignite-3/pull/5879#discussion_r2102329969
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/jdbc/ClientJdbcHasMoreRequest.java:
##########
@@ -31,19 +31,17 @@ public class ClientJdbcHasMoreRequest {
* Processes remote {@code JdbcGetMoreResultsRequest}.
*
* @param in Client message unpacker.
- * @param out Client message packer.
* @param handler Query event handler.
* @return Operation future.
*/
- public static CompletableFuture<Void> process(
+ public static CompletableFuture<ResponseWriter> process(
ClientMessageUnpacker in,
- ClientMessagePacker out,
JdbcQueryCursorHandler handler
) {
var req = new JdbcFetchQueryResultsRequest();
req.readBinary(in);
- return handler.getMoreResultsAsync(req).thenAccept(res ->
res.writeBinary(out));
+ return handler.getMoreResultsAsync(req).thenApply(res ->
res::writeBinary);
Review Comment:
[nitpick] Consider using a direct method reference (e.g.
thenApply(ResultType::writeBinary)) rather than wrapping it in a lambda, which
can improve readability.
```suggestion
return
handler.getMoreResultsAsync(req).thenApply(ResponseWriter::writeBinary);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
