sanpwc commented on code in PR #5824:
URL: https://github.com/apache/ignite-3/pull/5824#discussion_r2100009942
##########
modules/distribution-zones/src/main/java/org/apache/ignite/internal/distributionzones/rebalance/RebalanceRaftGroupEventsListener.java:
##########
@@ -181,19 +180,9 @@ public void
onNewPeersConfigurationApplied(PeersAndLearners configuration, long
}
try {
- rebalanceScheduler.schedule(() -> {
Review Comment:
Simply speaking, it's fragile and brings encapsulation leaks. It does not
block anymore - for sure someone may add leave-weight processing here and will
never detect that it's performed within raft thread. Same for exception
handling, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
