korlov42 commented on code in PR #5818:
URL: https://github.com/apache/ignite-3/pull/5818#discussion_r2100041413
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/ExplainRelAsTextWriter.java:
##########
@@ -78,6 +79,11 @@ protected void explain_(RelNode rel, List<Pair<String,
@Nullable Object>> values
if (value.right instanceof RelNode) {
continue;
}
+ if (rel instanceof IgniteMergeJoin) {
Review Comment:
I think, It's better to adjust
`org.apache.ignite.internal.sql.engine.rel.IgniteMergeJoin#explainTerms` in the
following way:
```
@Override
public RelWriter explainTerms(RelWriter pw) {
return super.explainTerms(pw)
.itemIf("leftCollation", leftCollation,
!ExplainUtils.forExplain(pw))
.itemIf("rightCollation", rightCollation,
!ExplainUtils.forExplain(pw));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
