ptupitsyn commented on code in PR #5853:
URL: https://github.com/apache/ignite-3/pull/5853#discussion_r2099924806
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/ClientTableCommon.java:
##########
@@ -392,7 +393,13 @@ public static CompletableFuture<TableViewInternal>
readTableAsync(ClientMessageU
* @param tx The transaction.
*/
public static void writeTxMeta(ClientMessagePacker out, @Nullable
ClockService clockService, InternalTransaction tx) {
- if (tx.remote()) {
+ if (out.resourceId() != 0) {
+ // Resource id is assigned on a first request in direct mode.
+ out.packLong(out.resourceId());
Review Comment:
Protocol change without a feature flag?
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/tx/ClientTransactionBeginRequest.java:
##########
@@ -113,11 +76,6 @@ public class ClientTransactionBeginRequest {
long resourceId = resources.put(new ClientResource(tx,
tx::rollbackAsync));
out.packLong(resourceId);
- if (enableDirectMapping && !readOnly) {
Review Comment:
Looks like a breaking change on protocol level, should we check the new
feature flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
