ascherbakoff commented on code in PR #5862:
URL: https://github.com/apache/ignite-3/pull/5862#discussion_r2099660105


##########
docs/_docs/administrators-guide/config/cluster-config.adoc:
##########
@@ -282,11 +279,9 @@ bin/ignite3 cluster config show > cluster-config.txt
 |======
 |Property|Default|Description|Changeable|Requires Restart|Acceptable Values
 
-|abandonedCheckTs|5000|The amount of time after which the transaction is 
considered abandoned.|Yes|Yes|0 - inf
-|attemptsObtainLock|3|The number of attempts to obtain a lock. After this 
number of attempts, a lock conflict exception is thrown on the transaction.| 
Yes | Yes | 0 - inf
-|implicitTransactionTimeout|3000|Timeout for implicit transactions. Used for 
key-value table APIs invoked with `null` instead of an explicit transaction 
instance. Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
-|rpcTimeout|6000|Timeout for the transaction operation. Used for table API 
operations.| Yes | Yes | 0 - inf
-|txnResourceTtl|30000|Time to live for transaction resources (transaction 
states, transaction nodes, open cursors, etc.). Should be higher than the lag 
to spread the actual transaction information across clusters. Otherwise, some 
transaction operations might take more time to find out the state from the 
persistence storage). Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
+|readOnlyTimeoutMillis|600000|Timeout for read-only transactions. It defines 
how long the transaction holds locks or write markers on participating nodes. 
If no timeout is specified, or it is set to `0`, a default value of 10 minutes 
is applied. The transaction is guaranteed to remain active until the timeout 
expires. Once the timeout is reached, the transaction is aborted but may 
persist briefly beyond the timeout while corresponding resources are cleaned 
up. Use instead of deprecated `readOnlyTimeout`. | Yes | No | 1 - inf

Review Comment:
   >It defines how long the transaction holds locks or write markers on 
participating nodes
   I would change it to something more undetailed, like 
   It defines how long the transaction holds necessary resources on 
participating nodes



##########
docs/_docs/administrators-guide/config/cluster-config.adoc:
##########
@@ -282,11 +279,9 @@ bin/ignite3 cluster config show > cluster-config.txt
 |======
 |Property|Default|Description|Changeable|Requires Restart|Acceptable Values
 
-|abandonedCheckTs|5000|The amount of time after which the transaction is 
considered abandoned.|Yes|Yes|0 - inf
-|attemptsObtainLock|3|The number of attempts to obtain a lock. After this 
number of attempts, a lock conflict exception is thrown on the transaction.| 
Yes | Yes | 0 - inf
-|implicitTransactionTimeout|3000|Timeout for implicit transactions. Used for 
key-value table APIs invoked with `null` instead of an explicit transaction 
instance. Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
-|rpcTimeout|6000|Timeout for the transaction operation. Used for table API 
operations.| Yes | Yes | 0 - inf
-|txnResourceTtl|30000|Time to live for transaction resources (transaction 
states, transaction nodes, open cursors, etc.). Should be higher than the lag 
to spread the actual transaction information across clusters. Otherwise, some 
transaction operations might take more time to find out the state from the 
persistence storage). Must be greater than `rpcTimeout`.| Yes | Yes | 0 - inf
+|readOnlyTimeoutMillis|600000|Timeout for read-only transactions. It defines 
how long the transaction holds locks or write markers on participating nodes. 
If no timeout is specified, or it is set to `0`, a default value of 10 minutes 
is applied. The transaction is guaranteed to remain active until the timeout 
expires. Once the timeout is reached, the transaction is aborted but may 
persist briefly beyond the timeout while corresponding resources are cleaned 
up. Use instead of deprecated `readOnlyTimeout`. | Yes | No | 1 - inf

Review Comment:
   >It defines how long the transaction holds locks or write markers on 
participating nodes
   
   I would change it to something more undetailed, like 
   It defines how long the transaction holds necessary resources on 
participating nodes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to