NSAmelchev commented on code in PR #12060:
URL: https://github.com/apache/ignite/pull/12060#discussion_r2095153343
##########
modules/core/src/main/java/org/apache/ignite/internal/IgnitionEx.java:
##########
@@ -1943,11 +1943,20 @@ private IgniteConfiguration
initializeConfiguration(IgniteConfiguration cfg)
* @param cfg Ignite configuration.
*/
private void initializeDataStorageConfiguration(IgniteConfiguration
cfg) throws IgniteCheckedException {
- if (cfg.getDataStorageConfiguration() != null &&
- (cfg.getMemoryConfiguration() != null ||
cfg.getPersistentStoreConfiguration() != null)) {
- throw new IgniteCheckedException("Data storage can be
configured with either legacy " +
- "(MemoryConfiguration, PersistentStoreConfiguration) or
new (DataStorageConfiguration) classes, " +
- "but not both.");
+ DataStorageConfiguration dsCfg = cfg.getDataStorageConfiguration();
+
+ if (dsCfg != null) {
+ if (cfg.getMemoryConfiguration() != null ||
cfg.getPersistentStoreConfiguration() != null) {
+ throw new IgniteCheckedException("Data storage can be
configured with either legacy " +
+ "(MemoryConfiguration, PersistentStoreConfiguration)
or new (DataStorageConfiguration) classes, " +
+ "but not both.");
+ }
+
+ List<String> extraNodeStorages =
F.asList(dsCfg.getExtraStoragePathes());
+
+ if (extraNodeStorages.size() != new
HashSet<>(extraNodeStorages).size()
+ || extraNodeStorages.contains(dsCfg.getStoragePath()))
+ throw new IgniteCheckedException("Data storage
configuration constains duplicates: " + extraNodeStorages);
Review Comment:
Let's add what exact configuration properties we are talking about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
