korlov42 commented on code in PR #5811:
URL: https://github.com/apache/ignite-3/pull/5811#discussion_r2095457273
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/Inbox.java:
##########
@@ -390,19 +391,14 @@ private void requestBatches(String nodeName, int cnt,
@Nullable SharedState stat
});
}
- /**
- * OnNodeLeft.
- * TODO Documentation https://issues.apache.org/jira/browse/IGNITE-15859
- */
- public void onNodeLeft(String nodeName) {
- if (context().originatingNodeName().equals(nodeName) && srcNodeNames
== null) {
- this.execute(this::close);
- } else if (srcNodeNames != null && srcNodeNames.contains(nodeName)) {
- this.execute(() -> onNodeLeft0(nodeName));
+ /** Notifies the inbox that provided node has left the cluster. */
+ public void onNodeLeft(ClusterNode node) {
+ if (srcNodeNames.contains(node.name())) {
Review Comment:
Currently, mapping is done around consistent names (table assignments,
colocation groups, routing of messages in mailboxes, etc). Since this
particular place doesn't cause queries to hang, I decided it would be better to
revise this part separately. First of all this requires some refactoring of
mapping subsystem; second, this will definitely affects mapped plan caching.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
