vldpyatkov commented on code in PR #5779:
URL: https://github.com/apache/ignite-3/pull/5779#discussion_r2080124878


##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/negotiation/LeaseNegotiator.java:
##########
@@ -90,6 +90,8 @@ public void negotiate(LeaseAgreement agreement) {
                             LOG.warn("Lease was not negotiated due to 
exception [lease={}]", throwable, lease);
                         }
 
+                        leaseToNegotiate.remove(agreement.groupId());

Review Comment:
   I am not sure that we can remove agreement by the group id. My concern is 
whether we are sure the agreement coincides with what is in leaseToNegotiate 
map.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to