timoninmaxim commented on code in PR #307:
URL: https://github.com/apache/ignite-extensions/pull/307#discussion_r2077052715
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteMetadataUpdater.java:
##########
@@ -137,7 +141,7 @@ public synchronized void updateMetadata() {
// (stored in 'offsets' field). If there are no offsets changes,
polling cycle is skipped.
Map<TopicPartition, Long> offsets0 = cnsmr.endOffsets(parts,
Duration.ofMillis(kafkaReqTimeout));
- if (!F.isEmpty(offsets0) && F.eqNotOrdered(offsets, offsets0)) {
+ if (!F.isEmpty(offsets0) && eqNotOrdered(offsets, offsets0)) {
Review Comment:
can be replaced with `offsets0.equals(offsets)`?
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteMetadataUpdater.java:
##########
@@ -31,6 +33,7 @@
import org.apache.ignite.cdc.TypeMapping;
import org.apache.ignite.internal.binary.BinaryContext;
import org.apache.ignite.internal.binary.BinaryMetadata;
+import org.apache.ignite.internal.binary.BinaryUtils;
Review Comment:
unused import
##########
modules/cdc-ext/src/main/java/org/apache/ignite/cdc/kafka/KafkaToIgniteMetadataUpdater.java:
##########
@@ -18,10 +18,12 @@
package org.apache.ignite.cdc.kafka;
import java.time.Duration;
+import java.util.Collection;
Review Comment:
unused import
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
