rpuch commented on code in PR #5763:
URL: https://github.com/apache/ignite-3/pull/5763#discussion_r2075967550
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/handlers/TxCleanupRecoveryRequestHandler.java:
##########
@@ -104,8 +107,11 @@ private void runPersistentStorageScan() {
});
}
} catch (IgniteInternalException e) {
- String errorMessage = String.format("Failed to scan transaction
state storage [commitPartition=%s].", replicationGroupId);
- failureProcessor.process(new FailureContext(e, errorMessage));
+ // TODO: https://issues.apache.org/jira/browse/IGNITE-25302 -
remove this IF after proper stop is implemented.
+ if (!hasCause(e, TxStateStorageClosedException.class,
TxStateStorageDestroyedException.class)) {
+ String errorMessage = String.format("Failed to scan
transaction state storage [commitPartition=%s].", replicationGroupId);
+ failureProcessor.process(new FailureContext(e, errorMessage));
+ }
}
LOG.debug("Persistent storage scan finished [committed={},
aborted={}].", committedCount, abortedCount);
Review Comment:
Why? We did some work and report it, even if we were interrupted early
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
