lowka commented on code in PR #5690: URL: https://github.com/apache/ignite-3/pull/5690#discussion_r2071583828
########## modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/utils/DatetimePair.java: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.sql.engine.planner.datatypes.utils; + +import org.apache.ignite.internal.type.NativeType; + +/** + * Enumerates possible datetime type pairs for test purposes. + */ +public enum DatetimePair implements TypePair { + DATE_DATE(Types.DATE, Types.DATE), + + TIME_0_TIME_0(Types.TIME_0, Types.TIME_0), + TIME_0_TIME_3(Types.TIME_0, Types.TIME_3), + TIME_0_TIME_6(Types.TIME_0, Types.TIME_6), + TIME_0_TIME_9(Types.TIME_0, Types.TIME_9), + + TIME_3_TIME_0(Types.TIME_3, Types.TIME_0), Review Comment: > all type pairs introduced so far describe unique-disregard-the-order pairs (i.e. there is TINYINT_SMALLINT but not SMALLINT_TINYINT). Could you please rephrase that or provide an example? Do you mean this the following? ``` TIME_0_TIME_0 TIME_0_TIME_3 TIME_0_TIME_6 TIME_0_TIME_9 ... TIME_3_TIME_3 TIME_3_TIME_6 TIME_3_TIME_9 .. TIME_9_TIME_? ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
