maksaska commented on code in PR #12015:
URL: https://github.com/apache/ignite/pull/12015#discussion_r2068478579
##########
modules/core/src/main/java/org/apache/ignite/internal/binary/GridBinaryMarshaller.java:
##########
@@ -291,6 +297,84 @@ public byte[] marshal(@Nullable Object obj, boolean
failIfUnregistered) throws B
}
}
+ /**
+ * @param in Input stream.
+ * @param clazz input object class.
+ * @return Binary object.
+ * @throws org.apache.ignite.binary.BinaryObjectException In case of error.
+ */
+ @Nullable public <T> T unmarshal(BinaryInputStream in, Class<?> clazz)
throws BinaryObjectException {
Review Comment:
Fixed
##########
modules/core/src/main/java/org/apache/ignite/internal/client/thin/ClientBinaryMarshaller.java:
##########
@@ -65,13 +64,14 @@ public <T> T unmarshal(BinaryInputStream in) {
}
/**
- * Deserializes object from input stream.
+ * Unmarshals Ignite binary object from input stream.
*
* @param in Input stream.
- * @param hnds Object handles.
+ * @param clazz input object class.
+ * @return Binary object.
*/
- public <T> T deserialize(BinaryInputStream in, BinaryReaderHandles hnds) {
- return impl.deserialize(in, null, hnds);
+ public <T> T unmarshal(BinaryInputStream in, Class<?> clazz) {
Review Comment:
Fixed it with #unwrapBinary()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
