rpuch commented on code in PR #5725:
URL: https://github.com/apache/ignite-3/pull/5725#discussion_r2068350842
##########
modules/index/src/main/java/org/apache/ignite/internal/index/IndexBuildController.java:
##########
@@ -554,10 +563,23 @@ private static IndexStorage indexStorage(
int partitionId,
CatalogIndexDescriptor indexDescriptor
) {
- IndexStorage indexStorage = mvTableStorage.getIndex(partitionId,
indexDescriptor.id());
+ IndexStorage indexStorage;
+ try {
+ indexStorage = mvTableStorage.getIndex(partitionId,
indexDescriptor.id());
+ } catch (StorageClosedException e) {
+ throw new TableClosedException(indexDescriptor.tableId(), e);
+ }
assert indexStorage != null : "Index storage is missing [partitionId="
+ partitionId + ", indexId=" + indexDescriptor.id() + "].";
return indexStorage;
}
+
+ private static class TableClosedException extends IgniteInternalException {
Review Comment:
This exception is local to this class, it's its private business (just to
improve the structure of the code, nothing more), so it would look a bit
confusing as a top-level exception. That's why I prefer to keep it inside. The
price is negligible: just a few lines of code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
