alievmirza commented on code in PR #5678:
URL: https://github.com/apache/ignite-3/pull/5678#discussion_r2066424180
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/causalitydatanodes/DistributionZoneCausalityDataNodesTest.java:
##########
@@ -213,6 +210,14 @@ void beforeEach() {
assertThat(metaStorageManager.deployWatches(),
willCompleteSuccessfully());
}
+ @AfterEach
+ void afterEach() throws InterruptedException {
+ if (tempPool != null) {
+ tempPool.shutdown();
Review Comment:
let's use `shutdownAndAwaitTermination`
##########
modules/distribution-zones/src/test/java/org/apache/ignite/internal/distributionzones/causalitydatanodes/DistributionZoneCausalityDataNodesTest.java:
##########
@@ -1205,7 +1207,7 @@ private void checkDataNodesRepeated(
// Above, we have waited for data nodes in meta storage to become the
same as in expectedDataNodesAfterTimersAreExpired map,
// so we use the applied revision and check the value of data nodes in
data nodes manager.
- HybridTimestamp timestamp =
metaStorageManager.timestampByRevisionLocally(metaStorageManager.appliedRevision());
+ HybridTimestamp timestamp =
metaStorageManager.timestampByRevisionLocally(keyValueStorage.revision());
Review Comment:
please review all comments were `topology augmentation` is mentioned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
