ibessonov commented on code in PR #5684:
URL: https://github.com/apache/ignite-3/pull/5684#discussion_r2059590135


##########
modules/metastorage/src/test/java/org/apache/ignite/internal/metastorage/server/AbstractCompactionKeyValueStorageTest.java:
##########
@@ -157,7 +157,7 @@ public void tearDown() throws Exception {
     void testCompactRevision1() {
         storage.compact(1);
 
-        assertEquals(List.of(3, 5), collectRevisions(FOO_KEY));
+        assertEquals(List.of(1, 3, 5), collectRevisions(FOO_KEY));

Review Comment:
   Sadly, that javadoc doesn't really define what it means by "compacted", and 
that's a source of great confusion among many people now. I will improve that 
javadoc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to