timoninmaxim commented on code in PR #11826:
URL: https://github.com/apache/ignite/pull/11826#discussion_r1928615513


##########
modules/core/src/main/java/org/apache/ignite/internal/management/performancestatistics/PerformanceStatisticsTask.java:
##########
@@ -65,7 +70,22 @@ protected PerformanceStatisticsJob(IgniteDataTransferObject 
arg, boolean debug)
         @Override protected String run(IgniteDataTransferObject arg) throws 
IgniteException {
             try {
                 if (arg instanceof PerformanceStatisticsStartCommandArg) {
-                    
ignite.context().performanceStatistics().startCollectStatistics();
+                    PerformanceStatisticsStartCommandArg startCmdArg = 
(PerformanceStatisticsStartCommandArg)arg;
+
+                    PerformanceStatisticsProcessor performanceStatisticsProc = 
ignite.context().performanceStatistics();
+                    GridSystemViewManager sysViewMgr = 
ignite.context().systemView();
+
+                    List<String> views;
+
+                    if (startCmdArg.allSystemViews()) {
+                        views = new ArrayList<>();
+                        sysViewMgr.forEach(view -> views.add(view.name()));
+                    }
+                    else if (startCmdArg.systemViews() != null) views = 
List.of(startCmdArg.systemViews());

Review Comment:
   Block of code after condition should be on own line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to