rpuch commented on code in PR #5670:
URL: https://github.com/apache/ignite-3/pull/5670#discussion_r2055402123
##########
modules/metastorage/src/main/java/org/apache/ignite/internal/metastorage/server/persistence/RocksDbKeyValueStorage.java:
##########
@@ -262,12 +272,11 @@ private enum RecoveryStatus {
/**
* Write options used to write to RocksDB.
*
- * <p>Access is guarded by {@link #rwLock}.
+ * <p>Metastorage recovery is based on the snapshot & external log. WAL is
never used for recovery, and can be safely disabled.
*/
- private WriteOptions writeOptions;
+ private static final WriteOptions WRITE_OPTIONS = new
WriteOptions().setDisableWAL(true);
Review Comment:
Please do, it seems safer to prevent any leak we can when it comes to RocksDB
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
