nizhikov commented on code in PR #11986:
URL: https://github.com/apache/ignite/pull/11986#discussion_r2052204404


##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/persistence/SnapshotCompatibilityTest.java:
##########
@@ -142,19 +135,33 @@ public void setUp() {
     /** */
     @Test
     public void testSnapshotRestore() throws Exception {
+        assumeFalse("Incremental snapshots for cache dump not supported", 
incSnp && cacheDump);
+
+        assumeFalse("Incremental snapshots require same consistentID", incSnp 
&& !customConsId);
+
+        assumeFalse("https://issues.apache.org/jira/browse/IGNITE-25096";, 
incSnp && oldNodesCnt == 3);
+
         try {
+            for (int i = 1; i < oldNodesCnt; ++i) {
+                startGrid(
+                    i,
+                    OLD_IGNITE_VERSION,
+                    new ConfigurationClosure(incSnp, consId(customConsId, i), 
customSnpPath, true, cacheGrpInfo)
+                );
+            }
+
             startGrid(
                 oldNodesCnt,
                 OLD_IGNITE_VERSION,
-                new ConfigurationClosure(incSnp, consId, customSnpPath, true, 
cacheGrpInfo),
+                new ConfigurationClosure(incSnp, consId(customConsId, 
oldNodesCnt), customSnpPath, true, cacheGrpInfo),
                 new CreateSnapshotClosure(incSnp, cacheDump, cacheGrpInfo)
             );
 
             stopAllGrids();
 
             cleanPersistenceDir(true);
 
-            IgniteEx node = startGrid(currentIgniteConfiguration(incSnp, 
consId, customSnpPath));
+            IgniteEx node = startGrid(currentIgniteConfiguration(incSnp, 
consId(customConsId, 1), customSnpPath));

Review Comment:
   We must start same count of nodes for old version and current version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to