alex-plekhanov commented on code in PR #11991:
URL: https://github.com/apache/ignite/pull/11991#discussion_r2042342650
##########
modules/core/src/main/java/org/apache/ignite/internal/management/snapshot/SnapshotCreateCommand.java:
##########
@@ -33,4 +37,12 @@ public class SnapshotCreateCommand extends
AbstractSnapshotCommand<SnapshotCreat
@Override public Class<SnapshotCreateTask> taskClass() {
return SnapshotCreateTask.class;
}
+
+ /** {@inheritDoc} */
+ @Override public String handleException(Exception e, Consumer<String>
printer) throws Exception {
+ if (X.hasCause(e, SnapshotWarningException.class))
Review Comment:
Java doc for `SnapshotOperationRequest#warnings`:
> Warnings do not interrupt snapshot process but raise exception at the end
to make the operation status 'not OK' if no other error occurred.
We should make this javadoc consistent with current behaviour.
What if one node has warnings and another node has errors? Do we have test
for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
