sashapolo commented on code in PR #5588:
URL: https://github.com/apache/ignite-3/pull/5588#discussion_r2041610588
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/raft/snapshot/PartitionSnapshotStorage.java:
##########
@@ -187,9 +211,20 @@ public FailureProcessor failureProcessor() {
* Starts an incoming snapshot.
*/
public SnapshotCopier startIncomingSnapshot(String uri) {
+ startSnapshotOperation();
+
SnapshotUri snapshotUri = SnapshotUri.fromStringUri(uri);
- var copier = new IncomingSnapshotCopier(this, snapshotUri,
incomingSnapshotsExecutor, waitForMetadataCatchupMs);
+ var copier = new IncomingSnapshotCopier(this, snapshotUri,
incomingSnapshotsExecutor, waitForMetadataCatchupMs) {
+ @Override
+ public void close() {
Review Comment:
How is it better? Callback approach looks like an abstraction leak to me.
What's wrong with the current approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
