rpuch commented on code in PR #5612:
URL: https://github.com/apache/ignite-3/pull/5612#discussion_r2039791573
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -3069,13 +3068,18 @@ public void
setStreamerReceiverRunner(StreamerReceiverRunner runner) {
}
public Set<TableImpl> zoneTables(int zoneId) {
- return tablesPerZone.computeIfAbsent(zoneId, id -> new HashSet<>());
+ return Set.copyOf(zoneTablesRawSet(zoneId));
Review Comment:
We only make defensive copies for external users (that is, for
DisasterRecoveryManager), these calls are extremely rare. For table/partition
operations, mutable set seems to be a cheaper approach
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
