lowka commented on code in PR #5578: URL: https://github.com/apache/ignite-3/pull/5578#discussion_r2032949151
########## modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz_timestamp.test: ########## @@ -0,0 +1,62 @@ +# name: test/sql/types/timestamp/test_timestamp.test Review Comment: Thanks. Fixed. ########## modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test: ########## @@ -0,0 +1,265 @@ +# name: test/sql/types/timestamp/test_timestamp.test +# description: Test TIMESTAMP WITH LOCAL TIME ZONE type +# group: [timestamp] + +statement ok +PRAGMA enable_verification + +statement ok +PRAGMA time_zone=Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR +---- +2017-07-23 13:10:11 Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11' +---- +2017-07-23T11:10:11Z + +statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal +SELECT TIMESTAMP WITH LOCAL TIME ZONE ' 2017-07-23 13:10:11 '; + +# other trailing, preceding, or middle gunk is not accepted +statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal +SELECT TIMESTAMP WITH LOCAL TIME ZONE ' 2017-07-23 13:10:11 AA'; + +query I +SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'); +---- +1992 + +query I +SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'::DATE); +---- +1992 + +query T +SELECT (TIMESTAMP '1992-01-01 01:01:01')::DATE; +---- +1992-01-01 + +query T +SELECT (TIMESTAMP '1992-01-01 01:01:01')::TIME; +---- +01:01:01 + +query T +SELECT (DATE '1992-01-01')::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR; +---- +1992-01-01 00:00:00 Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5' +---- +2007-12-31T23:00:01.500Z + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'::VARCHAR +---- +2008-01-01 00:00:01.5 Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999' +---- +2007-12-31T23:00:01.999Z + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'::VARCHAR +---- +2008-01-01 00:00:01.999 Europe/Paris + +# timestamp with large date +# actual error message is 000/-12-31 23:00:0 +# statement error: Date literal 'TIMESTAMP WITH LOCAL TIME ZONE '0000-01-01 00:00:01.5'' out of range +statement error +SELECT TIMESTAMP WITH LOCAL TIME ZONE '100000-01-01 00:00:01.5'::VARCHAR + +query T +SELECT '2008-01-01 00:00:01.999'::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR +---- +2008-01-01 00:00:01.999 Europe/Paris + +# Value must be rounded up. Review Comment: Fixed. ########## modules/sql-engine/src/integrationTest/sql/group1/types/timestamp/test_timestamp_ltz.test: ########## @@ -0,0 +1,265 @@ +# name: test/sql/types/timestamp/test_timestamp.test +# description: Test TIMESTAMP WITH LOCAL TIME ZONE type +# group: [timestamp] + +statement ok +PRAGMA enable_verification + +statement ok +PRAGMA time_zone=Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11'::VARCHAR +---- +2017-07-23 13:10:11 Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2017-07-23 13:10:11' +---- +2017-07-23T11:10:11Z + +statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal +SELECT TIMESTAMP WITH LOCAL TIME ZONE ' 2017-07-23 13:10:11 '; + +# other trailing, preceding, or middle gunk is not accepted +statement error: Illegal TIMESTAMP WITH LOCAL TIME ZONE literal +SELECT TIMESTAMP WITH LOCAL TIME ZONE ' 2017-07-23 13:10:11 AA'; + +query I +SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'); +---- +1992 + +query I +SELECT YEAR(TIMESTAMP '1992-01-01 01:01:01'::DATE); +---- +1992 + +query T +SELECT (TIMESTAMP '1992-01-01 01:01:01')::DATE; +---- +1992-01-01 + +query T +SELECT (TIMESTAMP '1992-01-01 01:01:01')::TIME; +---- +01:01:01 + +query T +SELECT (DATE '1992-01-01')::TIMESTAMP WITH LOCAL TIME ZONE::VARCHAR; +---- +1992-01-01 00:00:00 Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5' +---- +2007-12-31T23:00:01.500Z + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.5'::VARCHAR +---- +2008-01-01 00:00:01.5 Europe/Paris + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999' +---- +2007-12-31T23:00:01.999Z + +query T +SELECT TIMESTAMP WITH LOCAL TIME ZONE '2008-01-01 00:00:01.999'::VARCHAR +---- +2008-01-01 00:00:01.999 Europe/Paris + +# timestamp with large date +# actual error message is 000/-12-31 23:00:0 +# statement error: Date literal 'TIMESTAMP WITH LOCAL TIME ZONE '0000-01-01 00:00:01.5'' out of range Review Comment: Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
