zstan commented on code in PR #5479:
URL: https://github.com/apache/ignite-3/pull/5479#discussion_r2032911964
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/LimitNode.java:
##########
@@ -89,19 +93,30 @@ public void push(RowT row) throws Exception {
if (waiting == NOT_WAITING) {
return;
}
+
++rowsProcessed;
--waiting;
if (rowsProcessed > offset) {
- if (fetchNode == null || rowsProcessed <= fetch + offset) {
+ if (fetchUndefined || rowsProcessed <= fetch + offset) {
Review Comment:
it`s not true, just change it and run : ItLimitOffsetTest#testLimitOffset
all this checks have been wrote by blood)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
