rpuch commented on code in PR #5574:
URL: https://github.com/apache/ignite-3/pull/5574#discussion_r2031447791
##########
modules/core/src/main/java/org/apache/ignite/internal/failure/FailureContext.java:
##########
@@ -30,15 +30,49 @@ public class FailureContext {
/** Error. */
private final Throwable err;
+ /** Message describing the failure. */
+ private final String message;
+
/**
- * Creates instance of {@link FailureContext}.
+ * Creates instance of {@link FailureContext} of {@link
FailureType#CRITICAL_ERROR} type.
+ *
+ * @param err Exception.
+ */
+ public FailureContext(Throwable err) {
+ this(FailureType.CRITICAL_ERROR, err);
+ }
+
+ /**
+ * Creates instance of {@link FailureContext} corresponding to an unknown
failure.
*
* @param type Failure type.
* @param err Exception.
*/
public FailureContext(FailureType type, Throwable err) {
+ this(type, err, "Unknown error");
Review Comment:
Let's minimize the volume of changes in this PR, it's already too huge. The
current approach looks pretty natural, it's not something ugly that has to be
fixed asap :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
