ivanzlenko commented on code in PR #5472:
URL: https://github.com/apache/ignite-3/pull/5472#discussion_r2007066103
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/PagesWriteSpeedBasedThrottle.java:
##########
@@ -177,30 +180,74 @@ private void initMetrics(PersistentPageMemoryMetricSource
metricSource) {
assert cpLockStateChecker.checkpointLockIsHeldByThread();
long startTimeNs = System.nanoTime();
- long throttleParkTimeNs =
computeThrottlingParkTime(isPageInCheckpoint, startTimeNs);
+
+ long throttleParkTimeNs =
parkAndReturnParkingNanos(isPageInCheckpoint);
if (throttleParkTimeNs == NO_THROTTLING_MARKER) {
return;
- } else if (throttleParkTimeNs > 0) {
- recurrentLogIfNeeded();
- doPark(throttleParkTimeNs);
+ }
+
+ if (throttleParkTimeNs > LOGGING_THRESHOLD) {
+ LOG.warn("Parking thread=" + Thread.currentThread().getName() + "
for timeout(ms)=" + (throttleParkTimeNs / 1_000_000));
Review Comment:
```suggestion
LOG.warn("Parking thread={} for timeout(ms)={}",
Thread.currentThread().getName(), throttleParkTimeNs / 1_000_000);
```
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/throttling/PagesWriteSpeedBasedThrottle.java:
##########
@@ -44,6 +44,9 @@
public class PagesWriteSpeedBasedThrottle implements PagesWriteThrottlePolicy {
private static final IgniteLogger LOG =
Loggers.forClass(PagesWriteSpeedBasedThrottle.class);
+ /** Maximal time for a single {@link LockSupport#parkNanos(long)} call if
we don't throttle the checkpoint buffer. */
Review Comment:
```suggestion
/** The maximum time for a single {@link LockSupport#parkNanos(long)}
call if we don't throttle the checkpoint buffer. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
