rpuch commented on code in PR #5453:
URL: https://github.com/apache/ignite-3/pull/5453#discussion_r2004951865
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -544,23 +550,24 @@ public void onConfigurationCommitted(
storage.committedGroupConfiguration(config);
storage.lastApplied(lastAppliedIndex, lastAppliedTerm);
- if (!enabledColocation()) {
-
updateTrackerIgnoringTrackerClosedException(storageIndexTracker,
config.index());
- }
-
return null;
});
- byte[] configBytes = VersionedSerialization.toBytes(config,
RaftGroupConfigurationSerializer.INSTANCE);
+ if (!enabledColocation()) {
+
updateTrackerIgnoringTrackerClosedException(storageIndexTracker,
config.index());
+
+ byte[] configBytes = VersionedSerialization.toBytes(config,
RaftGroupConfigurationSerializer.INSTANCE);
Review Comment:
Do we do this update in the per-zone Raft listener?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/raft/PartitionListener.java:
##########
@@ -544,23 +550,24 @@ public void onConfigurationCommitted(
storage.committedGroupConfiguration(config);
storage.lastApplied(lastAppliedIndex, lastAppliedTerm);
- if (!enabledColocation()) {
-
updateTrackerIgnoringTrackerClosedException(storageIndexTracker,
config.index());
Review Comment:
Why is it moved outside?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
