nizhikov commented on code in PR #11938:
URL: https://github.com/apache/ignite/pull/11938#discussion_r2003776674
##########
modules/core/src/test/java/org/apache/ignite/marshaller/GridMarshallerAbstractTest.java:
##########
@@ -124,97 +81,14 @@ public abstract class GridMarshallerAbstractTest extends
GridCommonAbstractTest
}
};
- /** */
- protected GridMarshallerAbstractTest() {
- super(/*start grid*/true);
- }
-
- /** {@inheritDoc} */
- @Override protected IgniteConfiguration getConfiguration(String
igniteInstanceName) throws Exception {
- IgniteConfiguration cfg = super.getConfiguration(igniteInstanceName);
-
- CacheConfiguration namedCache = new
CacheConfiguration(DEFAULT_CACHE_NAME);
-
- namedCache.setName(CACHE_NAME);
- namedCache.setAtomicityMode(TRANSACTIONAL);
-
- cfg.setMarshaller(marshaller());
- cfg.setCacheConfiguration(new CacheConfiguration(DEFAULT_CACHE_NAME),
namedCache);
-
- return cfg;
- }
-
/**
* @return Marshaller.
*/
- protected abstract Marshaller marshaller();
+ protected abstract Marshaller marshaller() throws IgniteCheckedException;
/** {@inheritDoc} */
@Override protected void beforeTest() throws Exception {
- marsh = grid().configuration().getMarshaller();
- igniteInstanceName = grid().configuration().getIgniteInstanceName();
- }
-
- /**
- * @throws Exception If failed.
- */
- @Test
- public void testDefaultCache() throws Exception {
Review Comment:
Correct. Changes reverted.
##########
modules/core/src/test/java/org/apache/ignite/marshaller/jdk/GridJdkMarshallerSelfTest.java:
##########
@@ -1,33 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.ignite.marshaller.jdk;
-
-import org.apache.ignite.marshaller.GridMarshallerAbstractTest;
-import org.apache.ignite.marshaller.Marshaller;
-import org.apache.ignite.testframework.junits.common.GridCommonTest;
-
-/**
- * JDK marshaller self test.
- */
-@GridCommonTest(group = "Marshaller")
-public class GridJdkMarshallerSelfTest extends GridMarshallerAbstractTest {
Review Comment:
Correct. Changes reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
