nizhikov commented on code in PR #11910:
URL: https://github.com/apache/ignite/pull/11910#discussion_r2003079847
##########
modules/core/src/main/java/org/apache/ignite/internal/dto/IgniteDataTransferObject.java:
##########
@@ -118,25 +82,22 @@ public byte getProtocolVersion() {
/**
* Load object's specific data content.
*
- * @param protoVer Input object version.
* @param in Input object to load data content.
* @throws IOException If I/O errors occur.
* @throws ClassNotFoundException If the class for an object being
restored cannot be found.
*/
- protected abstract void readExternalData(byte protoVer, ObjectInput in)
throws IOException, ClassNotFoundException;
+ protected abstract void readExternalData(ObjectInput in) throws
IOException, ClassNotFoundException;
/** {@inheritDoc} */
@Override public void readExternal(ObjectInput in) throws IOException,
ClassNotFoundException {
int hdr = in.readInt();
- if ((hdr & MAGIC) != MAGIC)
+ if (hdr != MAGIC)
Review Comment:
Let's revert this line.
Looks like this will fix all tests you removed.
Let's revert changes in compatibility module to preserver compatibility
tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
