ptupitsyn commented on code in PR #5402:
URL: https://github.com/apache/ignite-3/pull/5402#discussion_r1998515610
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -681,16 +684,25 @@ private void processOperation(ChannelHandlerContext ctx,
ClientMessageUnpacker i
return null;
case ClientOp.TABLES_GET:
- return ClientTablesGetRequest.process(out,
igniteTables).thenRun(() -> {
- out.meta(clockService.current());
- });
+ if
(clientContext.hasFeature(ServerProtocolBitmaskFeature.TABLE_GET_REQS_USE_QUALIFIED_NAME))
{
+ return ClientTablesGetRequestV2.process(out,
igniteTables).thenRun(() -> {
+ out.meta(clockService.current());
+ });
+ } else {
+ return ClientTablesGetRequest.process(out,
igniteTables).thenRun(() -> {
+ out.meta(clockService.current());
+ });
+ }
case ClientOp.SCHEMAS_GET:
return ClientSchemasGetRequest.process(in, out, igniteTables,
schemaVersions);
case ClientOp.TABLE_GET:
- return ClientTableGetRequest.process(in, out, igniteTables);
-
+ if
(clientContext.hasFeature(ServerProtocolBitmaskFeature.TABLE_GET_REQS_USE_QUALIFIED_NAME))
{
+ return ClientTableGetRequestV2.process(in, out,
igniteTables);
+ } else {
+ return ClientTableGetRequest.process(in, out,
igniteTables);
+ }
Review Comment:
```suggestion
}
```
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java:
##########
@@ -681,16 +684,25 @@ private void processOperation(ChannelHandlerContext ctx,
ClientMessageUnpacker i
return null;
case ClientOp.TABLES_GET:
- return ClientTablesGetRequest.process(out,
igniteTables).thenRun(() -> {
- out.meta(clockService.current());
- });
+ if
(clientContext.hasFeature(ServerProtocolBitmaskFeature.TABLE_GET_REQS_USE_QUALIFIED_NAME))
{
Review Comment:
I think a cleaner approach is to introduce separate op codes:
`ClientOp.TABLES_GET_QUALIFIED` and `TABLE_GET_QUALIFIED`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
