rpuch commented on code in PR #5391:
URL: https://github.com/apache/ignite-3/pull/5391#discussion_r1995100403
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -469,13 +468,15 @@ private void cleanUpResourcesForDroppedZonesOnRecovery() {
// TODO: IGNITE-20384 Clean up abandoned resources for dropped zones
from vault and metastore
}
- private CompletableFuture<Void> onCreateZone(CreateZoneEventParameters
createZoneEventParameters) {
+ private CompletableFuture<Boolean> onCreateZone(CreateZoneEventParameters
createZoneEventParameters) {
Review Comment:
To have ability to declare the listener simply using a method reference:
`private final EventListener<CreateZoneEventParameters> onCreateZoneListener
= this::onCreateZone;`
Because `EventListener`'s method requires `CompletableFuture<Boolean>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
