AMashenkov commented on code in PR #5368: URL: https://github.com/apache/ignite-3/pull/5368#discussion_r1987105867
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/rel/SortNode.java: ########## @@ -154,6 +154,12 @@ public void end() throws Exception { flush(); } + private void doFlush() throws Exception { + checkState(); Review Comment: Most likely yes, you are right. I would do this in a separate ticket with getting rid of checking state on each loop iteration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org