rpuch commented on code in PR #5385:
URL: https://github.com/apache/ignite-3/pull/5385#discussion_r1988507919
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java:
##########
@@ -322,7 +323,7 @@ public PartitionReplicaLifecycleManager(
this.partitionOperationsExecutor = partitionOperationsExecutor;
this.clockService = clockService;
this.executorInclinedSchemaSyncService = new
ExecutorInclinedSchemaSyncService(schemaSyncService,
partitionOperationsExecutor);
- this.placementDriver = placementDriver;
+ this.placementDriver = new
ExecutorInclinedPlacementDriver(placementDriver, partitionOperationsExecutor);
Review Comment:
```suggestion
this.executorInclinedPlacementDriver = new
ExecutorInclinedPlacementDriver(placementDriver, partitionOperationsExecutor);
```
We use this naming pattern in `TableManager` and at least for schema sync
service in `PartitionReplicaLifecycleManager`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
