alex-plekhanov commented on code in PR #11903:
URL: https://github.com/apache/ignite/pull/11903#discussion_r1982760485
##########
modules/core/src/main/java/org/apache/ignite/configuration/SqlConfiguration.java:
##########
@@ -242,4 +261,32 @@ public QueryEngineConfiguration[]
getQueryEnginesConfiguration() {
@Override public String toString() {
return S.toString(SqlConfiguration.class, this);
}
+
+ /**
+ * Returns the default SQL plan history size based on the SQL engine. If
no engine is configured, H2 is used by
+ * default as per {@link GridQueryProcessor}.
+ *
+ * @return The default SQL query plan history size.
+ */
+ private int defaultSqlPlanHistorySize() {
Review Comment:
I propose avoid to bring any logic, especially reflection, to configuration,
since it must be POJO and also public API.
Instead, let's modify RunningQueryManager to something like this:
```
planHistSz = ctx.config().getSqlConfiguration().getSqlPlanHistorySize() < 0
&& !ctx.query().indexingEnabled()
? SqlConfiguration.DFLT_SQL_PLAN_HISTORY_SIZE
: ctx.config().getSqlConfiguration().getSqlPlanHistorySize();
```
And make default value for this parameter -1.
Also, let's remove mentions about H2/Calcite from config, refer to H2 engine
as 'indexing module' and Calcite engine as 'other engines'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
