AMashenkov commented on code in PR #5324: URL: https://github.com/apache/ignite-3/pull/5324#discussion_r1979610774
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/ExecutionContext.java: ########## @@ -132,6 +137,9 @@ public ExecutionContext( this.originatingNodeName = originatingNodeName; this.txAttributes = txAttributes; this.timeZoneId = timeZoneId; + this.inBufSize = inBufSize < 0 ? Commons.IN_BUFFER_SIZE : inBufSize; Review Comment: Or maybe '0' should means no-buffering? I prefer having magic constant like `-1`, which mean not-specified, than thinking what does '0' could means. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org