alex-plekhanov commented on code in PR #11905:
URL: https://github.com/apache/ignite/pull/11905#discussion_r1979164772
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/CorrelatedNestedLoopJoinPlannerTest.java:
##########
@@ -160,4 +105,55 @@ public void testInvalidIndexExpressions() throws Exception
{
checkSplitAndSerialization(phys, publicSchema);
}
+
+ /** */
+ @Test
+ public void testFilterPushDown() throws Exception {
+ IgniteSchema publicSchema = new IgniteSchema("PUBLIC");
+
+ publicSchema.addTable("T0", testTable(null));
+ publicSchema.addTable("T1", testTable(null));
Review Comment:
```
createSchema(
createTable("T0", IgniteDistributions.broadcast(), "ID", Integer.class,
"JID", Integer.class, "VAL", String.class),
...
)
```
##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/CorrelatedNestedLoopJoinPlannerTest.java:
##########
@@ -160,4 +105,55 @@ public void testInvalidIndexExpressions() throws Exception
{
checkSplitAndSerialization(phys, publicSchema);
}
+
+ /** */
+ @Test
+ public void testFilterPushDown() throws Exception {
+ IgniteSchema publicSchema = new IgniteSchema("PUBLIC");
+
+ publicSchema.addTable("T0", testTable(null));
+ publicSchema.addTable("T1", testTable(null));
+
+ String sql = "select * " +
+ "from t0 " +
+ "where t0.val > 'value' and exists (select * from t1 where
t0.jid = t1.jid);";
+
+ IgniteRel phys = physicalPlan(sql, publicSchema);
+
+ System.out.println("+++ " + RelOptUtil.toString(phys));
+
+ assertNotNull(phys);
+
+ IgniteFilter filter = findFirstNode(phys, byClass(IgniteFilter.class));
+
+ assertNull("IgniteFilter must not be used.", filter);
+
+ IgniteTableScan tblScan = findFirstNode(
+ phys,
+ byClass(IgniteTableScan.class, (tbl) ->
tbl.getTable().getQualifiedName().contains("T1")));
+
+ assertNotNull("Where condition must be push downed to
IgniteTableScan.", tblScan.condition());
Review Comment:
It's an old, deprecated approach to check the plan. It's better to use
`assertPlan` (it's less verbose, easier to understand and also has additional
checks, like plan serialization)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
