tkalkirill commented on code in PR #5328:
URL: https://github.com/apache/ignite-3/pull/5328#discussion_r1977049198
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/VolatilePageMemoryDataRegion.java:
##########
@@ -72,7 +76,12 @@ public class VolatilePageMemoryDataRegion implements
DataRegion<VolatilePageMemo
* Starts the in-memory data region.
*/
public void start() {
- VolatilePageMemory pageMemory = new VolatilePageMemory(cfg,
ioRegistry, pageSize);
+ int lockConcLvl = IgniteSystemProperties.getInteger(
+ IGNITE_OFFHEAP_LOCK_CONCURRENCY_LEVEL,
+
Integer.highestOneBit(Runtime.getRuntime().availableProcessors() * 4)
Review Comment:
Why not use this new constant?
`OffheapReadWriteLock.DEFAULT_CONCURRENCY_LEVEL`
##########
modules/page-memory/src/integrationTest/java/org/apache/ignite/internal/pagememory/tree/AbstractBplusTreePageMemoryTest.java:
##########
@@ -3265,15 +3206,6 @@ protected static void println(@Nullable String msg) {
System.out.println(msg);
Review Comment:
Ok
##########
modules/core/src/main/java/org/apache/ignite/internal/util/OffheapReadWriteLock.java:
##########
@@ -33,6 +33,9 @@
* </pre>
*/
public class OffheapReadWriteLock {
+ /** Default concurrency level for the lock. */
+ public static final int DEFAULT_CONCURRENCY_LEVEL = 128;
Review Comment:
Could you describe why exactly 128 and not 64 or 256?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
