JAkutenshi commented on code in PR #5300:
URL: https://github.com/apache/ignite-3/pull/5300#discussion_r1976483821
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##########
@@ -649,6 +649,33 @@ public void testScanCloseReplicaRequest() throws Exception
{
assertDoesNotThrow(tx::commit);
}
+ @Test
+ public void testNodeStop() throws Exception {
+ // Prepare a single node cluster.
+ startCluster(1);
+ Node node = getNode(0);
+
placementDriver.setPrimary(node.clusterService.topologyService().localMember());
Review Comment:
Agree, but I had to merge the current main
##########
modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/LocalPartitionReplicaEvent.java:
##########
@@ -28,6 +28,11 @@ public enum LocalPartitionReplicaEvent implements Event {
*/
BEFORE_REPLICA_STARTED,
+ /**
+ * Fired when partition replica has been just stopped and the related
partition shouldn't be destroyed then e.g. on Ignite node stop.
Review Comment:
Fixed, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
