PakhomovAlexander commented on code in PR #5209:
URL: https://github.com/apache/ignite-3/pull/5209#discussion_r1975296494
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/InternalTransaction.java:
##########
@@ -117,9 +117,10 @@ void enlist(
* @param executionTimestamp The timestamp is the time when a read-only
transaction is applied to the remote node. The parameter
* is not used for read-write transactions.
* @param full Full state transaction marker.
+ * @param timeoutExceeded Timeout exceeded flag (commit flag must be
{@code false}).
* @return The future.
*/
- CompletableFuture<Void> finish(boolean commit, @Nullable HybridTimestamp
executionTimestamp, boolean full);
+ CompletableFuture<Void> finish(boolean commit, @Nullable HybridTimestamp
executionTimestamp, boolean full, boolean timeoutExceeded);
Review Comment:
This is a very good proposal. Do you think I should implement this in
current PR or create a ticket?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
