sanpwc commented on code in PR #5310: URL: https://github.com/apache/ignite-3/pull/5310#discussion_r1975233703
########## modules/partition-replicator/src/main/java/org/apache/ignite/internal/partition/replicator/PartitionReplicaLifecycleManager.java: ########## @@ -364,6 +368,8 @@ public CompletableFuture<Void> startAsync(ComponentContext componentContext) { rebalanceRetryDelayConfiguration.init(); + placementDriver.listen(PrimaryReplicaEvent.PRIMARY_REPLICA_EXPIRED, this::onPrimaryReplicaExpired); Review Comment: I guess it's not required. Neither there's such code in the source that was used to port given logic. I see that you've created a ticket for that https://issues.apache.org/jira/browse/IGNITE-24673 Let's discuss it there, WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org