ivanzlenko commented on code in PR #5297:
URL: https://github.com/apache/ignite-3/pull/5297#discussion_r1975034874
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/ExecutionDistributionProviderImpl.java:
##########
@@ -81,10 +85,10 @@ private CompletableFuture<List<TokenizedAssignments>>
collectAssignments(
int partitions = table.partitions();
if (includeBackups) {
- List<TablePartitionId> replicationGroupIds = new
ArrayList<>(partitions);
+ List<ReplicationGroupId> replicationGroupIds = new
ArrayList<>(partitions);
for (int p = 0; p < partitions; p++) {
- replicationGroupIds.add(new TablePartitionId(table.id(), p));
+ replicationGroupIds.add(targetReplicationGroupId(table, p));
Review Comment:
```suggestion
replicationGroupIds.add(targetReplicationGroupId(table,
partitionId));
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/ExecutionDistributionProviderImpl.java:
##########
@@ -81,10 +85,10 @@ private CompletableFuture<List<TokenizedAssignments>>
collectAssignments(
int partitions = table.partitions();
if (includeBackups) {
- List<TablePartitionId> replicationGroupIds = new
ArrayList<>(partitions);
+ List<ReplicationGroupId> replicationGroupIds = new
ArrayList<>(partitions);
for (int p = 0; p < partitions; p++) {
Review Comment:
```suggestion
for (int partitionId = 0; partitionId < partitions;
partitionId++) {
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/ExecutionDistributionProviderImpl.java:
##########
@@ -94,7 +98,7 @@ private CompletableFuture<List<TokenizedAssignments>>
collectAssignments(
// no need to wait all partitions after pruning was implemented.
for (int partId = 0; partId < partitions; ++partId) {
- ReplicationGroupId partGroupId = new TablePartitionId(table.id(),
partId);
+ ReplicationGroupId partGroupId = targetReplicationGroupId(table,
partId);
Review Comment:
```suggestion
ReplicationGroupId partGroupId = targetReplicationGroupId(table,
partitionId);
```
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/exec/mapping/ExecutionDistributionProviderImpl.java:
##########
@@ -94,7 +98,7 @@ private CompletableFuture<List<TokenizedAssignments>>
collectAssignments(
// no need to wait all partitions after pruning was implemented.
for (int partId = 0; partId < partitions; ++partId) {
Review Comment:
```suggestion
for (int partitionId = 0; partitionId < partitions; ++partitionId) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
