ivanzlenko commented on code in PR #5292:
URL: https://github.com/apache/ignite-3/pull/5292#discussion_r1974583587


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/exec/ExecutableTableRegistrySelfTest.java:
##########
@@ -61,6 +61,7 @@
  */
 @ExtendWith(MockitoExtension.class)
 public class ExecutableTableRegistrySelfTest extends BaseIgniteAbstractTest {
+    private static final int TEST_ZONE_ID = 1;

Review Comment:
   From my perspective, it is better to have a constant rather than chuck 
random value into the constructor.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to