ivanzlenko commented on code in PR #5299:
URL: https://github.com/apache/ignite-3/pull/5299#discussion_r1971605445
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java:
##########
@@ -1240,6 +1239,17 @@ static void onHeartbeatReturned(final ThreadId id, final
Status status, final Ap
}
}
+ private static void logFailToIssueRpc(Status status, Replicator r) {
Review Comment:
Let's name it replicator :)
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java:
##########
@@ -1240,6 +1239,17 @@ static void onHeartbeatReturned(final ThreadId id, final
Status status, final Ap
}
}
+ private static void logFailToIssueRpc(Status status, Replicator r) {
+ if (status.getRaftError() == RaftError.ENOENT) {
+ // Maybe the target node was not able to start yet, no need to
WARN here.
+ LOG.info("Fail to issue RPC to {}, consecutiveErrorTimes={},
error={}", r.options.getPeerId(),
+ r.consecutiveErrorTimes, status);
Review Comment:
I would've move r.options.getPeerId() and r.consecutiveErrorTimes into
variables just to improve readability.
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/Replicator.java:
##########
@@ -1240,6 +1239,17 @@ static void onHeartbeatReturned(final ThreadId id, final
Status status, final Ap
}
}
+ private static void logFailToIssueRpc(Status status, Replicator r) {
+ if (status.getRaftError() == RaftError.ENOENT) {
+ // Maybe the target node was not able to start yet, no need to
WARN here.
Review Comment:
Can we move it to javaDoc?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
