sk0x50 commented on code in PR #5224:
URL: https://github.com/apache/ignite-3/pull/5224#discussion_r1971441795
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/ItReplicaLifecycleTest.java:
##########
@@ -759,21 +742,23 @@ public void testTableEstimatedSize(TestInfo testInfo)
throws Exception {
assertDoesNotThrow(() -> keyValueView2.putAll(tx, kv2));
});
-
- // Read the key from another transaction to trigger write intent
resolution, and so incrementing the estimated size.
- // TODO https://issues.apache.org/jira/browse/IGNITE-24384
Perhaps, it should be reworked some way
- // when the write intent resolution will be 're-implemented' using
colocation feature.
- node.transactions().runInTransaction(tx -> {
- keyValueView1.getAll(tx, kv1.keySet());
-
- keyValueView2.getAll(tx, kv2.keySet());
- });
-
- CompletableFuture<Long> sizeFuture1 =
node.tableManager.table(tableId1).internalTable().estimatedSize();
- CompletableFuture<Long> sizeFuture2 =
node.tableManager.table(tableId2).internalTable().estimatedSize();
-
- assertEquals(kv1.size(), sizeFuture1.get());
- assertEquals(kv2.size(), sizeFuture2.get());
+//
+// // Read the key from another transaction to trigger write intent
resolution, and so incrementing the estimated size.
+// // TODO https://issues.apache.org/jira/browse/IGNITE-24384
Perhaps, it should be reworked some way
+// // when the write intent resolution will be 're-implemented'
using colocation feature.
+// node.transactions().runInTransaction(tx -> {
+// keyValueView1.getAll(tx, kv1.keySet());
+//
+// keyValueView2.getAll(tx, kv2.keySet());
+// });
+//
+// CompletableFuture<Long> sizeFuture1 =
node.tableManager.table(tableId1).internalTable().estimatedSize();
+// CompletableFuture<Long> sizeFuture2 =
node.tableManager.table(tableId2).internalTable().estimatedSize();
+//
+// assertEquals(kv1.size(), sizeFuture1.get());
+// assertEquals(kv2.size(), sizeFuture2.get());
+
+ Thread.sleep(1000);
Review Comment:
Looks like a debugging artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
