rpuch commented on code in PR #5283:
URL: https://github.com/apache/ignite-3/pull/5283#discussion_r1969141205
##########
modules/network/src/integrationTest/java/org/apache/ignite/internal/network/netty/ItConnectionManagerTest.java:
##########
@@ -308,7 +305,26 @@ public void testConnectMisconfiguredClient() throws
Exception {
public void testStartTwice() throws Exception {
ConnectionManagerWrapper server = startManager(4000);
- assertThrows(IgniteInternalException.class,
server.connectionManager::start);
+ IgniteInternalException exception = (IgniteInternalException)
assertThrows(
Review Comment:
How about making `assertThrows()` generic (as it is in `Assertions`) to get
rid of this ugly cast?
##########
modules/network/src/integrationTest/java/org/apache/ignite/internal/network/netty/ItConnectionManagerTest.java:
##########
@@ -308,7 +305,26 @@ public void testConnectMisconfiguredClient() throws
Exception {
public void testStartTwice() throws Exception {
ConnectionManagerWrapper server = startManager(4000);
- assertThrows(IgniteInternalException.class,
server.connectionManager::start);
+ IgniteInternalException exception = (IgniteInternalException)
assertThrows(
+ IgniteInternalException.class,
+ server.connectionManager::start,
+ "Attempted to start an already started connection manager"
+ );
+
+ assertEquals("IGN-CMN--1", exception.codeAsString());
Review Comment:
Is this how we render 65535? Let's file an issue and fix this separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
