lowka commented on code in PR #5256:
URL: https://github.com/apache/ignite-3/pull/5256#discussion_r1967269299
##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/datatypes/NumericFunctionsTypeCoercionTest.java:
##########
@@ -1153,18 +1153,18 @@ public void overlay(NumericPair pair, Matcher<RexNode>
arg1, Matcher<RexNode> ar
TestBuilders.table()
.name("T")
.distribution(IgniteDistributions.single())
- .addColumn("C1", NativeTypes.STRING)
+ .addColumn("C1", NativeTypes.stringOf(32))
.addColumn("C2", pair.first())
.addColumn("C3", pair.second())
.build()
);
- RelDataType varchar =
Commons.typeFactory().createSqlType(SqlTypeName.VARCHAR);
+ RelDataType varchar =
Commons.typeFactory().createSqlType(SqlTypeName.VARCHAR, 64);
Review Comment:
`OVERLAY` uses `DYADIC_STRING_SUM_PRECISION` that computes sums precision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
