korlov42 commented on code in PR #5248: URL: https://github.com/apache/ignite-3/pull/5248#discussion_r1967172619
########## modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/sql/ClientSqlCancelRequest.java: ########## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.client.handler.requests.sql; + +import java.util.Map; +import java.util.concurrent.CompletableFuture; +import org.apache.ignite.internal.client.proto.ClientMessagePacker; +import org.apache.ignite.internal.client.proto.ClientMessageUnpacker; +import org.apache.ignite.internal.util.CompletableFutures; +import org.apache.ignite.lang.CancelHandle; + +/** + * Request to cancel execution of a SQL query previously initiated on the same connection. + */ +public class ClientSqlCancelRequest { + /** + * Processes the request. + */ + public static CompletableFuture<Void> process( + ClientMessageUnpacker in, + ClientMessagePacker out, + Map<Long, CancelHandle> cancelHandleMap + ) { + long correlationToken = in.unpackLong(); + CancelHandle cancelHandle = cancelHandleMap.remove(correlationToken); + + if (cancelHandle != null) { + return cancelHandle.cancelAsync(); + } + + return CompletableFutures.nullCompletedFuture(); Review Comment: this seems suspicious... Is it possible to cancel the same query twice using only public API? My concern is, if first request will trigger cancellation and remove handler from `cancelHandleMap`, then second cancellation will return immediately even though resources associated with the handle may still be held. This violates the contract provided by `CancelHandle` ########## modules/core/src/main/java/org/apache/ignite/lang/CancelHandleHelper.java: ########## @@ -78,6 +78,10 @@ public static void addCancelAction( addCancelAction(token, () -> completionFut.cancel(true), completionFut); } + public static boolean isCancelled(CancellationToken token) { Review Comment: it would be nice to add javadoc to a new method. Let's mention that if this method returns `true`, this only means that cancellation has been triggered (therefore new operations must not be started), but not necessary has been completed yet, implying that resources held by operation may still be acquired -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
