denis-chudov commented on code in PR #5252:
URL: https://github.com/apache/ignite-3/pull/5252#discussion_r1965614365
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/VolatileTxStateMetaStorage.java:
##########
@@ -171,39 +170,34 @@ public CompletableFuture<Void> vacuum(
} else if (TxState.isFinalState(meta0.txState())) {
Long initialVacuumObservationTimestamp =
meta0.initialVacuumObservationTimestamp();
- if (initialVacuumObservationTimestamp == null &&
txnResourceTtl > 0) {
- markedAsInitiallyDetectedTxnsCount.incrementAndGet();
Review Comment:
`markedAsInitiallyDetectedTxnsCount` is it still needed?
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/VolatileTxStateMetaStorage.java:
##########
@@ -171,39 +170,34 @@ public CompletableFuture<Void> vacuum(
} else if (TxState.isFinalState(meta0.txState())) {
Long initialVacuumObservationTimestamp =
meta0.initialVacuumObservationTimestamp();
Review Comment:
why still `Long`? maybe make `initialVacuumObservationTimestamp()` not
nullable and add `requireNonNull` here?
##########
modules/transactions/src/integrationTest/java/org/apache/ignite/tx/distributed/ItTxResourcesVacuumTest.java:
##########
@@ -1054,7 +1056,25 @@ private IgniteImpl anyNode() {
@Nullable
private static TransactionMeta volatileTxState(IgniteImpl node, UUID txId)
{
TxManagerImpl txManager = (TxManagerImpl) node.txManager();
- return txManager.stateMeta(txId);
+
+ TxStateMeta txInMemoryState = txManager.stateMeta(txId);
+
+ if (txInMemoryState == null) {
+ return null;
+ }
+
+ long current = FastTimestamps.coarseCurrentTimeMillis();
+
Review Comment:
remove one empty line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
